Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GROW-2928): Upgrade the gcp terraform version #1637

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

leijin-lw
Copy link
Contributor

@leijin-lw leijin-lw commented Jun 4, 2024

Summary

Upgrade the gcp terraform version to use gcp 5.0 module.

How did you test this change?

Issue

@leijin-lw leijin-lw requested a review from a team as a code owner June 4, 2024 22:56
@leijin-lw leijin-lw requested a review from ipcrm June 4, 2024 22:57
Signed-off-by: Lei Jin <lei.jin@lacework.net>
Copy link
Contributor

@ipcrm ipcrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, for now let's just update the module you had problems with. We need to plan how to test all of these since multiple are making major version jumps.

Signed-off-by: Lei Jin <lei.jin@lacework.net>
@leijin-lw
Copy link
Contributor Author

Thanks for the updates, for now let's just update the module you had problems with. We need to plan how to test all of these since multiple are making major version jumps.

Sure. I will only change the self-deployment after merge this PR.

@leijin-lw leijin-lw requested a review from ipcrm June 5, 2024 18:45
Signed-off-by: Lei Jin <lei.jin@lacework.net>
@leijin-lw leijin-lw merged commit 02bccca into main Jun 5, 2024
12 checks passed
@leijin-lw leijin-lw deleted the leijin-gcp-version branch June 5, 2024 19:25
@lacework-releng lacework-releng mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants